Re: kicad build w/o wayland still failing?

[Thomas Klausner <wiz%gatalith.at@localhost>]

On Sun, Dec 15, 2024 at 02:23:53PM -0600, John D. Baker wrote:
> Now I remember.  The patch in PR pkg/58339 uses the
> 
>   CMAKE_ARGS+=foo
> 
> idiom.  This was later changed to:
> 
>   CMAKE_CONFIGURE_ARGS+=foo
> 
> but the patch was never adapted to the new preferred style.
> 
> Thus the patch _as committed_ to "cad/kicad/options.mk" won't flag any
> errors because "CMAKE_ARGS+=" is still a valid syntax, it won't do what
> is intended.
> 
> Most likely the bulk build systems have wayland support installed so they
> silently succeed while a system without wayland fails as mine does.
> 
> Thus "cad/kicad/options.mk" needs to have any instances of "CMAKE_ARGS"
> updated to "CMAKE_CONFIGURE_ARGS".

Committed, thanks!
 Thomas