Re: kicad build w/o wayland still failing?

[Rob Whitlock <rwhitlock22%gmail.com@localhost>]

> On Dec 15, 2024, at 3:23 PM, John D. Baker <jdbaker%consolidated.net@localhost> wrote:
> 
> Now I remember.  The patch in PR pkg/58339 uses the
> 
>  CMAKE_ARGS+=foo
> 
> idiom.  This was later changed to:
> 
>  CMAKE_CONFIGURE_ARGS+=foo
> 
> but the patch was never adapted to the new preferred style.
> 
> Thus the patch _as committed_ to "cad/kicad/options.mk" won't flag any
> errors because "CMAKE_ARGS+=" is still a valid syntax, it won't do what
> is intended.
> 
> Most likely the bulk build systems have wayland support installed so they
> silently succeed while a system without wayland fails as mine does.
> 
> Thus "cad/kicad/options.mk" needs to have any instances of "CMAKE_ARGS"
> updated to "CMAKE_CONFIGURE_ARGS".

Sorry about that. I had thought I tested the new patch before I sent it, but somehow it still succeeded. I later noticed this when it failed for me and I sent a message to the PR with the fix.

Thanks for fixing this up, everyone.