Re: devel/hdf5-c++ and ninja

[Thomas Klausner <wiz%gatalith.at@localhost>]

On Wed, Mar 05, 2025 at 12:40:23PM -0500, Greg Troxel wrote:
> Thomas Klausner <wiz%gatalith.at@localhost> writes:
> 
> > .include "../../mk/bsd.prefs.mk"
> > # building only a subdirectory using BUILD_DIRS is not supported with
> > # the ninja generator
> > CMAKE_GENERATOR=        make
> 
> I added this without bsd.prefs.mk and a test build went fine.  pkglint
> -Wall is clean, except
> 
>   NOTE: Makefile:13: Definition of CMAKE_GENERATOR is redundant because of ../../devel/cmake/build.mk:76.
> 
> which seems slightly off because = is not ?= but that's not important
> and separate.
> 
> Is bsd.prefs.mk necessary to handle the case when the user's mk.conf
> sets CMAKE_GENERATOR to ninja with = instead of ?=, so that the pkg
> Makefile setting is later?  If so, should we really be overriding the
> user's setting with bare =?

Yes, we should if we know it doesn't work because we don't have
separate flags for what a package supports and what the user requests
yet.

bsd.prefs.mk is needed exactly for that case.

> I realize this is a slippery slope to CMAKE_GENERATORS_SUPPORTED and we
> are blurring pkg-settable and user-settable variables.  (I think we're
> headed to not being pure about the distinction as long as this is good
> enough.)

Exactly!
 Thomas