Re: new package: gallery2

[Fredrik Pettai <pettai%nordu.net@localhost>]

On Sep 8, 2008, at 4:20 AM, OBATA Akio wrote:
> On Mon, 08 Sep 2008 08:04:04 +0900, Fredrik Pettai  
> <pettai%nordu.net@localhost> wrote:
>> On Sep 6, 2008, at 4:37 AM, OBATA Akio wrote:
>>>> do-install:
>>>>    ${INSTALL_DATA} ${WRKDIR}/gallery2.conf ${EGDIR}/gallery2.conf
>>>>    ${CP} -R ${WRKSRC}/* ${G2DIR}
>>>>    ${CHMOD} 666 ${G2DIR}/config.php
>>>>    ${INSTALL_DATA} ${FILESDIR}/.htaccess ${G2DIR}/.htaccess
>>>
>>> You can add DESTDIR support.
>>
>> I fixed most of the things you "enlightened" me about by commenting  
>> my
>> package submissions.
>> But I'm not sure how you mean I should do with adding DESTDIR  
>> support?
>> I didn't find much documented about DESTDIR in the pkgsrc doc.
>> What benefit does it offer? And how should I call it in the Makefile?
>> (I've looked in several other Makefiles of some other packages, and
>> there are lot of ways that DESTDIR is called/used...)
>
> The pkgsrc guide
> 5.3. Variables affecting the installation process
> 19.6.4. Adding DESTDIR support to packages
>
> For this package, it's easy to support DESTDIR.
> Just define PKG_DESTDIR_SUPPORT=user-destdir and
> change do-install target to installation directory prefixed with $ 
> {DESTDIR}.

Hmm... my pkgsrc PDF didn't that text in it, I have to download a  
newer version.

> So I suggested to add DESTDIR support.

Okay, I think I have fixed all your suggestions now (in all the  
packages).

However, there is one irritating thing left, and it's during the  
deinstallation of gallery2.
You get a error message:

pkg_delete: unable to completely remove directory '/usr/pkg/share/ 
gallery2'
pkg_delete: couldn't entirely delete package `gallery2-2.2.5'
(perhaps the packing list is incorrectly specified?)
= 
= 
= 
========================================================================
The following files are no longer being used by gallery2-2.2.5,
and they can be removed if no other packages are using them:

         /usr/pkg/share/gallery2/config.php

This is because of the configration file is copied to /usr/pkg/share/ 
gallery2/config.php, and the PLIST (which has @rmdir /usr/pkg/share/ 
gallery2).
I think that most people want to have the gallery2 folder deleted then  
they deinstall gallery2.
But it's also nice to leave the config.php there if it has been  
modified. But as it is now, I don't get either of those...

How do I solve that in the best way?

Thanks,
/P

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review