RE: please review wip/polarssl

[Tim Larson <Tim.Larson%proxibid.com@localhost>]

> DESCR should mention GPL in passing; a library intended to be usable in
> embedded products being GPL is not what I'd expect.  (I don't mean to
> object to someone writing and distributing a library, or to it being
> packaged.  I would just expect that most actual products would rule it
> out, so it seems good to add "GPL-licensed" to the DESCR (not to be
> pointed; just add the words so people perceive reality efficiently).

Please clarify. Do you suggest this because a GPL (as opposed to LGPL) library seems odd? (I'd agree, but that's what it is. There is some mention of exceptions, but I didn't chase that down.)

> pkglint complains:
>
> ERROR: patches/patch-Makefile:1: "$NetBSD$" expected.
> ERROR: patches/patch-Makefile:1: Comment expected.

Thought I'd done this but must have forgotten to save.  Now when I add "$NetBSD$" it still complains about the comment. What comment am I supposed to add?

> Is PKGSRC_RUN_TEST documented in the guide?  I have been unclear on how
> this is supposed to work, but it seems sensible.

It is.

==>
PKGSRC_RUN_TEST can be set to “yes” to run each package's self-test before installing it. Note that some packages make heavy use of “good” random numbers, so you need to assure that the machine on which you are doing the bulk builds is not completely idle. Otherwise some test programs will seem to hang, while they are just waiting for new random data to be available.
<==

Not sure if this means the infrastructure will automatically assume a "make test" is to be done, or if it just gives you a hook to optionally do that step yourself, or what, but it is there.

> Why is REPLACE_PERL outside of ifdef while USE_TOOLS is in?

I'm not completely sure what the previous packager was trying to do regarding the test suite, but I wanted to leave that in. Not moving the USE_TOOLS line was my error, though.

> It probably needs FETCH_USING=curl due to https; it won't fetch for me.

OK thanks.


Tim
--

Tim Larson
Software Engineer

e: Tim.Larson%proxibid.com@localhost
p: 877-505-7770
d: 402-505-7770

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify by return email. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.

Warning: Although the company has taken reasonable precautions to ensure no viruses are present in this email, no assurance or warranty is given that this email and any attachments are free of viruses.

------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov

_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review