Re: New package devel/py-tortoisehg

["Kamil Rytarowski" <n54%gmx.com@localhost>]

----- Original Message -----
From: Niclas Rosenvik
Sent: 03/30/14 09:38 AM
To: Kamil Rytarowski
Subject: Re: New package devel/py-tortoisehg
 On Sat, 29 Mar 2014 19:16:09 +0100
"Kamil Rytarowski" <n54%gmx.com@localhost> wrote:

> ----- Original Message -----
> From: Thomas Klausner
> Sent: 03/28/14 08:58 AM
> To: Kamil Rytarowski
> Subject: Re: New package devel/py-tortoisehg
> On Fri, Mar 28, 2014 at 03:45:45AM +0100, Kamil Rytarowski wrote:
> > I've packaged TortoiseHG, it's a GUI for the Mercurial VCS.
> > 
> > The package is available on github [1], on my public account.
> > 
> > [1]
> > https://github.com/krytarowski/pkgsrc-2013Q4/tree/tortoisehg/devel/py-tortoisehg
> 
> Please take a look at the already existing wip/tortoisehg (perhaps the
> name should be changed) and merge any improvements you have.
> 
> Thanks,
> Thomas
> 
> ----
> 
> Hello!
> Funny, when I started to work on tortoisehg, it was still absent. As
> this is new package still in-progress and I'm new here, I'm attaching
> a patch with my possibly changes: 1) Add python to CATEGORIES 2)
> Rename to py-tortoisehg (as purely Python) 3) Mercurial's Python
> version compatibility (the trick from py-hgview) 4) Use ${RUN} for
> shell commands (I supposed we need it always)
> 
When did you start to work on your py-tortoisehg? The tortoisehg in
pkgsrc-wip was added on 13 february 2014.
Thanks for pointing about ${RUN}, this was new to me.

There is one thing not mentioned in the diff you sent that is different 
in the Makefile on your github account. You are using distutils more
properly by using distutils.mk. I think you should add this to the
changes you make:
Remove PYDISTUTILSPKG=yes ,replace extension.mk with distutils.mk and
update the PLIST. Default PLIST changes means also to bump PKGREVISION.


> The last thing, I don't understand the purpose of USE_LANGUAGES= c
> for a pure python-software?
The reason is to silence a warning that is displayed after running make.
WARNING: *** Please consider adding c to USE_LANGUAGES in the package
Makefile.
This one comes up when the Makefile includes the line 
USE_LANGUAGES= #none
this is put into it by url2pkg then url2pkg can't find any c, fortran
or c++ files.
The warning can be silenced by not having an USE_LANGUAGES line at all 
in the Makefile(I guess since USE_LANGUAGES=c is the default) so you can
remove it. It will look better that way. :)
> 
> I'm waiting for your feedback and green light to apply the changes.
> 
> With regards,

Please apply the changes.

Kind regards,
Niclas Rosenvik 


-----

Hello,

Thank you for your review.

I can only assume that my upfront analysis what-do-package was before 14th Feb. 
My first package (already pending for 2014Q1) devel/py-hgview (originally 
devel/hgview) was branched from wip/hgview.

For the distutils part I wasn't sure whether my version is better or just 
different.

I'm waiting for write-access from Thomas (already submitted my request) to 
patch the package.

Thank you for your great work on wip/tortoisehg!

Regards,

------------------------------------------------------------------------------
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review