Re: New package devel/py-tortoisehg

["Kamil Rytarowski" <n54%gmx.com@localhost>]

----- Original Message -----
From: Thomas Klausner
Sent: 03/30/14 03:18 PM
To: Kamil Rytarowski
Subject: Re: New package devel/py-tortoisehg
 Hi!

On Sat, Mar 29, 2014 at 07:16:09PM +0100, Kamil Rytarowski wrote:
> Funny, when I started to work on tortoisehg, it was still absent. As this is 
> new package still in-progress and I'm new here, I'm attaching a patch with my 
> possibly changes:
> 1) Add python to CATEGORIES
> 2) Rename to py-tortoisehg (as purely Python)
> 3) Mercurial's Python version compatibility (the trick from py-hgview)

These are fine.

> 4) Use ${RUN} for shell commands (I supposed we need it always)

Hm, I never use that :)
It's just:
misc/common.mk:RUN= ${_PKG_SILENT}${_PKG_DEBUG} set -e;

> The last thing, I don't understand the purpose of USE_LANGUAGES= c for a pure 
> python-software?

It's wrong. If the package doesn't use a compiler, remove the line and
ignore the warning you get.

> +.include "../../lang/python/pyversion.mk"
> 
> .include "../../lang/python/application.mk"

This is also unnecessary, application.mk will pull it in for us.
 Thomas 

----

Hello,

Thank you for your comments on the package. I'll go for ${RUN} as it sets 
useful and wider-controllable flags -- also, I like this feature!

I will remove my FETCH_USING, as it's targeted for an end-user (in etc/mk.conf) 
and it unnecessarily sets that in this package, someone else would prefer some 
other tool.

Thank you again!

With kind regards,

------------------------------------------------------------------------------
_______________________________________________
pkgsrc-wip-review mailing list
pkgsrc-wip-review%lists.sourceforge.net@localhost
https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review