Port-i386 archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: NET4501 w/options IPSEC breaks ipv6 at compile time?



On Mon, Jun 18, 2012 at 07:03:05PM -0400, Greg Troxel wrote:
> 
> If you have time, it would be really interesting to add -S to the
> compile lines for that file
> 
>   with -O2 and without your change
>   with -O2 and with your change
>   with -Os and your change
> 
> and read the assembly.  I suspect that in the -O2 case the NULL
> assignment is optimized out, because the compiler can provde that it
> wasn't necessary, and with -Os it's present, because that proof wasn't
> successful and hence the failure.
> 
> Any objections to me adding the NULL assignment?

That's exactly the reason why I don't like GCC's -Wuninitialize.
If code changes, changes are always that a real bug slipped through.

Joerg


Home | Main Index | Thread Index | Old Index