Re: x86/include/cacheinfo.h

[SAITOH Masanobu <msaitoh%execsw.org@localhost>]

 Hi, all.

(2013/07/18 0:13), Masao Uebayashi wrote:
> I'm not familiar with x86 either, but quickly looked at the manual.
> The patch looks correct.
> 
> On Wed, Jul 17, 2013 at 11:57 PM, Christos Zoulas 
> <christos%astron.com@localhost> wrote:
>> In article <51E62CAD.5030709%execsw.org@localhost>,
>> Masanobu SAITOH  <msaitoh%execsw.org@localhost> wrote:
>>> While I'm checking Intel's document, I found some bugs in cacheinfo.h.
>>> The file includes INTEL_CACHE_INFO macro. The values in the macro are
>>> described in "Table 3-22 Encoding of CPUID Leaf 2 Descriptors, Intel 64
>>> and IA-32 Architectures Software Developer's Manual Vol. 2A."
>>>
>>> For the entry of 0x0d, cai_linesize is wrong but the value is not
>>> used in kernel if my understanding is correct.
>>>
>>> For the entry of 0xeb, cai_totalsize is wrong and the value is used
>>> for the page coloring. Does this bug cause a serious problem?
>>>
>>> I'm sorry that I'm not familiar with x86 :(
>>
>> I don't know, but file a PR so that it does not get lost!
>>
>> christos

 I'll commit that fix soon. IMHO, it's not so important to file a PR
because that change will be noted in CHANGES-6.2 when I pull up.

-- 
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)