Re: CVS commit: src/lib/libc/time

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Mon, Dec 14, 2009 at 06:15:21AM +0000, David Holland wrote:
> On Mon, Dec 14, 2009 at 05:51:57AM +0000, Matt Thomas wrote:
>  > Suppress a warning if time_t is __int64_t
> 
> -                               } while ((sse * 10 <= TIME_MAX) &&
> +                               } while (((uint64_t)(sse * 10) <= TIME_MAX) &&
> 
> Don't you want ((uint64_t)sse * 10 <= TIME_MAX), that is, cast before
> multiplying?

The best approach is to not multiply at all, but divide the constant...

Joerg