Re: CVS commit: src/lib/libc/time

To: David Holland <dholland-sourcechanges%netbsd.org@localhost>, source-changes-d%NetBSD.org@localhost, matt%netbsd.org@localhost
Subject: Re: CVS commit: src/lib/libc/time
From: David Holland <dholland-sourcechanges%netbsd.org@localhost>
Date: Tue, 15 Dec 2009 05:21:05 +0000

On Mon, Dec 14, 2009 at 03:56:14PM +0100, Joerg Sonnenberger wrote:
 > > -                               } while ((sse * 10 <= TIME_MAX) &&
 > > +                               } while (((uint64_t)(sse * 10) <= 
 > > TIME_MAX) &&
 > > 
 > > Don't you want ((uint64_t)sse * 10 <= TIME_MAX), that is, cast before
 > > multiplying?
 > 
 > The best approach is to not multiply at all, but divide the constant...

heh, indeed...

-- 
David A. Holland
dholland%netbsd.org@localhost

References:
- Re: CVS commit: src/lib/libc/time
  - From: David Holland
- Re: CVS commit: src/lib/libc/time
  - From: Joerg Sonnenberger

Prev by Date: Re: CVS commit: src/external/bsd/ntp
Next by Date: Re: CVS commit: src/tools/gdb
Previous by Thread: Re: CVS commit: src/lib/libc/time
Next by Thread: Re: CVS commit: src/sys/kern
Indexes:

Home | Main Index | Thread Index | Old Index