Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src



On Fri, Mar 12, 2010 at 09:53:16PM +0000, Darran Hunt wrote:
> Module Name:  src
> Committed By: darran
> Date:         Fri Mar 12 21:53:16 UTC 2010
> 
> Modified Files:
>       src/distrib/sets/lists/modules: mi
>       src/external/cddl/osnet/dev/fbt: fbt.c
>       src/external/cddl/osnet/dist/uts/common/dtrace: dtrace.c
>       src/sys/modules/dtrace: Makefile
>       src/sys/sys: module.h
> Added Files:
>       src/sys/modules/dtrace/fbt: Makefile
> 
> Log Message:
> DTrace: Add the Function Boundary Trace (FBT) provider moduile.  This
> module  instruments every function in the kernel with entry and exit
> probes.  These probes are true zero-effect probes in that they don't
> exist in the code until they are enabled.  The probes are enabled by
> directly patching the function entry and exit points to make jumps into
> the dtrace framework.
> This gives us over 29,000 trace points in the kernel.

Amazing work!

However,

> +#include <machine/cpu.h>
> +#include <machine/cpufunc.h>
> +#include <machine/specialreg.h>
> +#if 0
> +#include <x86/cpuvar.h>
> +#endif
> +#include <x86/cputypes.h>
> +
> +#define ELFSIZE ARCH_ELFSIZE
> +#include <sys/exec_elf.h>

As this is obviously MD code, the source should be organised in a way
so that at least it is clear that the functionality is not available on
archs other than i386 and amd64.

-- 
Quentin Garnier - cube%cubidou.net@localhost - cube%NetBSD.org@localhost
"See the look on my face from staying too long in one place
[...] every time the morning breaks I know I'm closer to falling"
KT Tunstall, Saving My Face, Drastic Fantastic, 2007.

Attachment: pgptUnunfbo0C.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index