Re: CVS commit: src/sys/fs/tmpfs

[Anders Magnusson <ragge%ludd.ltu.se@localhost>]

On 05/14/2011 10:34 AM, Marc Balmer wrote:
> Am 10.05.11 02:34, schrieb Matt Thomas:
> > Module Name:    src
> > Committed By:   matt
> > Date:           Tue May 10 00:34:26 UTC 2011
> >
> > Modified Files:
> >         src/sys/fs/tmpfs: tmpfs_vnops.c
> >
> > Log Message:
> > yes, more C99 please (back out previous change).
> After this committ/back-out/back-out-pf-the-back-out fest I have a
> technical question:
>
> What is the current state of C99 vs. older Cs?  Do all arches /
> compilers we have support C99?  I assume gcc, llvm/clang are safe, but
> what about pcc wrt C99?
pcc should be C99 compliant. If something do not work as expected, I'll 
fix it.

-- Ragge

> I'd like a short clarification here, since this might influence my
> coding...  tnx.
>
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.79 -r1.80 src/sys/fs/tmpfs/tmpfs_vnops.c
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> >
> >
> >
> >
> > Modified files:
> >
> > Index: src/sys/fs/tmpfs/tmpfs_vnops.c
> > diff -u src/sys/fs/tmpfs/tmpfs_vnops.c:1.79 src/sys/fs/tmpfs/tmpfs_vnops.c:1.80
> > --- src/sys/fs/tmpfs/tmpfs_vnops.c:1.79 Sun May  8 00:03:35 2011
> > +++ src/sys/fs/tmpfs/tmpfs_vnops.c      Tue May 10 00:34:26 2011
> > @@ -1,4 +1,4 @@
> > -/*     $NetBSD: tmpfs_vnops.c,v 1.79 2011/05/08 00:03:35 christos Exp $        
> > */
> > +/*     $NetBSD: tmpfs_vnops.c,v 1.80 2011/05/10 00:34:26 matt Exp $    */
> >
> >   /*
> >    * Copyright (c) 2005, 2006, 2007 The NetBSD Foundation, Inc.
> > @@ -35,7 +35,7 @@
> >    */
> >
> >   #include<sys/cdefs.h>
> > -__KERNEL_RCSID(0, "$NetBSD: tmpfs_vnops.c,v 1.79 2011/05/08 00:03:35 christos Exp 
> > $");
> > +__KERNEL_RCSID(0, "$NetBSD: tmpfs_vnops.c,v 1.80 2011/05/10 00:34:26 matt Exp 
> > $");
> >
> >   #include<sys/param.h>
> >   #include<sys/dirent.h>
> > @@ -1466,8 +1466,7 @@
> >
> >   #if defined(DEBUG)
> >         if (!error&&  pgs) {
> > -               int i;
> > -               for (i = 0; i<  npages; i++) {
> > +               for (int i = 0; i<  npages; i++) {
> >                         KASSERT(pgs[i] != NULL);
> >                 }
> >         }