Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/external/bsd/atf/dist



On 11/16/11 3:11 PM, Christos Zoulas wrote:
In article<4EC40D98.4070507%NetBSD.org@localhost>,
Julio Merino<jmmv%NetBSD.org@localhost>  wrote:

I know there is no portable way, but at least we can default to "do
nothing" if this is not supported.  It's better than "not building" :-P

Oh, I can arrange that. #ifdef __NetBSD__ :-)
But in my view this is worse...

Yeah, leave it as is for now. I'll have to do something similar anyway though, but if I can implement the code for the most common systems, that's probably good enough.

Yes, they are small because this is just one change.  But more may come.
  I'll then have to go and rewrite all these local changes with
portability in mind.  When the time to integrate a new release comes,
I'll have to mess around with lots merge conflicts, because the upstream
code will look nothing like what we have (hence why I asked for this to
be reviewed first).

Well, this is the world we live in. Next time be the one to upgrade gdb
or binutils or ssh and have to deal with 10-50K lines of diffs.
You will not be complaining about a 100 line conflict after that :-)

That's true... but do we have a chance of getting things integrated into gdb "quickly" and/or on our own to prevent those 10-50K diffs? For atf we do ;-) (OK, I can definitely try to improve on the "quickly" side...) Anyway, just something to keep in mind.

Still, I'd appreciate running changes for review at least. I'm open to "overlooking" details like these that don't fit upstream if that's going to make things easier temporarily.

Home | Main Index | Thread Index | Old Index