Re: CVS commit: src/sys/dev/pci

[Paul Goyette <paul%whooppee.com@localhost>]

On Wed, 29 Aug 2012, Paul Goyette wrote:

> On Wed, 29 Aug 2012, Manuel Bouyer wrote:
>
> > Module Name:    src
> > Committed By:   bouyer
> > Date:           Wed Aug 29 20:39:24 UTC 2012
> >
> > Modified Files:
> >         src/sys/dev/pci: if_wm.c if_wmreg.h
> >
> > Log Message:
> > Make vlan and all ip/ip6 checksum offload work for the I350.
> >
> > On newer devices, when using the legacy TX descriptors, vlan-related flags
> > that were set on the last descriptor of a packet have to be set on the
> > first one.
> > For tso/checksum offloads, a new "advanced" descriptor format has to be
> > used.
> <snip>
> > Tested on a I350, and a i80003 (which use the old format), both with and
> > without vlans, with and without checksum offloads.
>
> Is there an easy way to identify which wm I have?  Does the following device 
> need this commit in order to use offload?  Or will this one work with an 
> earlier rev of the driver?
>
> # dmesg | grep wm
> wm0 at pci2 dev 0 function 0: Intel i82574L (rev. 0x00)
> wm0: interrupting at ioapic1 pin 24
> wm0: PCI-Express bus
> wm0: 256 word (8 address bits) SPI EEPROM
> wm0: Ethernet address bc:ae:c5:30:d9:8a
> ukphy0 at wm0 phy 1: OUI 0x000ac2, model 0x000b, rev. 1

BTW, reason I am asking is that I had previously (about a year or so 
ago) needed to disable the offload functions on the 82574 because it 
wasn't working.  This commit seems to imply that it fixes only the I350 
so I was wondering if some other change that I had missed might have 
already fixed the 82574.



-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------