Re: CVS commit: src/sys/dev/pci

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Wed, Aug 29, 2012 at 02:53:53PM -0700, Paul Goyette wrote:
> >Tested on a I350, and a i80003 (which use the old format), both with and
> >without vlans, with and without checksum offloads.
> 
> Is there an easy way to identify which wm I have?  Does the
> following device need this commit in order to use offload?  Or will
> this one work with an earlier rev of the driver?
> 
> # dmesg | grep wm
> wm0 at pci2 dev 0 function 0: Intel i82574L (rev. 0x00)
> wm0: interrupting at ioapic1 pin 24
> wm0: PCI-Express bus
> wm0: 256 word (8 address bits) SPI EEPROM
> wm0: Ethernet address bc:ae:c5:30:d9:8a
> ukphy0 at wm0 phy 1: OUI 0x000ac2, model 0x000b, rev. 1

The new queue is for i82575 and newer. the i82574L should be fine with
the old queue interface.

On Wed, Aug 29, 2012 at 03:06:20PM -0700, Paul Goyette wrote:
> BTW, reason I am asking is that I had previously (about a year or so
> ago) needed to disable the offload functions on the 82574 because it
> wasn't working.  This commit seems to imply that it fixes only the
> I350 so I was wondering if some other change that I had missed might
> have already fixed the 82574.

This commit fixes only the I350 because it's the only one I can test,
but the new queue interface should probably be used for all
WM_F_NEWQUEUE devices (which are: 82575, 82576, 82580 and I350).

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--