Re: CVS commit: src/sys/arch/arm

[David Laight <david%l8s.co.uk@localhost>]

On Sun, Dec 09, 2012 at 07:32:11PM -0800, Matt Thomas wrote:
> 
> On Dec 9, 2012, at 6:02 PM, Christos Zoulas wrote:
> 
> > In article <20121210013731.5B86C175DF%cvs.netbsd.org@localhost>,
> > Matt Thomas <source-changes-d%NetBSD.org@localhost> wrote:
> >> -=-=-=-=-=-
> >> 
> >> Module Name:       src
> >> Committed By:      matt
> >> Date:              Mon Dec 10 01:37:31 UTC 2012
> >> 
> >> Modified Files:
> >>    src/sys/arch/arm/arm32: arm32_machdep.c cpuswitch.S fault.c genassym.cf
> >>        vm_machdep.c
> >>    src/sys/arch/arm/include: pcb.h
> >> 
> >> Log Message:
> >> Rename pcb_sp/PCB_SP to pcb_ksp/PCB_KSP so that ipsec.c will compile.
> > 
> > I already fixed that on head, in ipsec.c
> 
> I think <sys/proc.h> including <machine/pcb.h> is wrong.
> 
> Nothing in <machine/pcb.h> needs to be used by MI code.

Not only that, sys/proc.h is a posix specified header.
It really wants splitting into 3:
1) the bits posix says it should have, needed by userspace.
2) the kernel public bits, used by normal drivers
3) the bits that are private to the process handling code & scheduler.

        David

-- 
David Laight: david%l8s.co.uk@localhost