Re: CVS commit: src/sys/arch

[David Holland <dholland-sourcechanges%netbsd.org@localhost>]

On Sun, Dec 09, 2012 at 11:27:14AM -0600, David Young wrote:
 > > Modified Files:
 > >    src/sys/arch/i386/i386: db_interface.c trap.c
 > >    src/sys/arch/x86/x86: bus_dma.c cpu.c platform.c
 > > 
 > > Log Message:
 > > #ifdef - #endif-ed. NMCA, NISA, NNPX, NIOAPIC, LAPIC, MPBIOS and 
 > > MULTIPROCESSOR.
 > 
 > Please, add no new #ifdefs.  Let config(1) and the linker configure the
 > kernel.

That's a nice theory. In all likelihood most of these ifdefs are
required to make the system compilable when one or more of these
config items is turned off, and "fixing" it is not likely
straightforward.

-- 
David A. Holland
dholland%netbsd.org@localhost