Re: CVS commit: src/sys/arch

[David Holland <dholland-sourcechanges%netbsd.org@localhost>]

On Mon, Dec 10, 2012 at 10:09:01AM -0800, Paul Goyette wrote:
 > >> > Modified Files:
 > >> >         src/sys/arch/i386/i386: db_interface.c trap.c
 > >> >         src/sys/arch/x86/x86: bus_dma.c cpu.c platform.c
 > >> >
 > >> > Log Message:
 > >> > #ifdef - #endif-ed. NMCA, NISA, NNPX, NIOAPIC, LAPIC, MPBIOS and 
 > >> > MULTIPROCESSOR.
 > >>
 > >> Please, add no new #ifdefs.  Let config(1) and the linker configure the
 > >> kernel.
 > >
 > >That's a nice theory. In all likelihood most of these ifdefs are
 > >required to make the system compilable when one or more of these
 > >config items is turned off, and "fixing" it is not likely
 > >straightforward.
 > 
 > Possibly true.
 > 
 > But as I have shown in a separate thread, it is now no longer
 > possible to build an amd64 system with MULTIPROCESSOR but without
 > MPBIOS.  This is something that has previously worked just fine,
 > and is implied by the comments in amd64/conf/GENERIC as valid
 > configuration.
 > 
 > I have submitted separate patch (on current-users) to fix this
 > specific situation, but who knows how many more previously-working
 > combinations are now broken due to these changes?

Probably a lot. I'm not saying piles of ifdefs are good; I'm just
saying that there are usually reasons they need to be there and
reorganizing everything to eliminate them is not trivial. (And, also,
not necessarily desirable.)

Anyway, thanks for fixing this particular instance.

-- 
David A. Holland
dholland%netbsd.org@localhost