Source-Changes-D archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/distrib/atari/floppies/install
joerg@ wrote:
> > > > "Please don't commit untested and broken fix."
> > > > "Please file a PR instead if you can't test it."
> > >
> > > I agree with Christos that leaving the build broken is worse. The
> > > alternative band aids are much more involved, too. That shouldn't stop
> > > the second point from that list.
> >
> > If you claim leaving the build broken is worse than commiting untested code,
> > you should ask to update our commit guideline first:
>
> Bumping the size of a floppy is definitely the smaller evil. Can you
> please try to be reasonable?
I'm not sure what's your definition of "definitely",
but bumping the size of a floppy is fatal on atari,
as you can see in the first message of this thread.
Our commit guideline is quite reasonable:
>> ask a developer who is familiar with that part of the system for
>> review.
---
Izumi Tsutsui
Home |
Main Index |
Thread Index |
Old Index