Re: CVS commit: src/distrib/atari/floppies/install

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Sun, Apr 26, 2015 at 10:07:32AM -0400, Greg Troxel wrote:
> 
> Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost> writes:
> 
> > joerg@ wrote:
> >
> >> > "Please don't commit untested and broken fix."
> >> > "Please file a PR instead if you can't test it."
> >> 
> >> I agree with Christos that leaving the build broken is worse.  The
> >> alternative band aids are much more involved, too. That shouldn't stop
> >> the second point from that list.
> >
> > If you claim leaving the build broken is worse than commiting untested code,
> > you should ask to update our commit guideline first:
> >
> > http://www.netbsd.org/developers/commit-guidelines.html
> 
> Perhaps we should.  The problems are:
> 
>   A broken build is evidence that the prior commits were not tested, and
>   thus need fixing.  Objecting to fixing the build without testing
>   should be a far lower priority than objecting to commits that break
>   the build.

The problem here is that the original commit that triggered the overflow
can and often enough is perfectly reasonable on all platforms without
artifically low size constraints. What is needed to get at least basic
regression testing done in an emulator?

Joerg