Re: sys/modules/spkr

[Paul Goyette <paul%whooppee.com@localhost>]

On Fri, 9 Dec 2016, I wrote (but not cc'd to source-changes-d):

> I noticed that you updated spkr.c to retain the existing default behavior
> of "spkr* at pcppi?"
>
> Do you have any intention to provide a synth_spkr module which would use
> your new capabilities?  It looks like it would be fairly trivial.

Also, rather than using #ifdef PCPPISPEAKER to conditionalize large 
chunks of dev/isa/spkr.c it seems to me that a better approach would 
have been to split the existing file into common code, and adding a new 
file for the pcppi attachment stuff.



+------------------+--------------------------+------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
+------------------+--------------------------+------------------------+