Re: sys/modules/spkr

[Nathanial Sloss <nat%netbsd.org@localhost>]

Hi Paul,

Thanks, for making a module of spkr_synth.

Spkr and spkr synth are undergoing a lot of changes so I can't wait to see 
what happens and hopefully I'll be able to help the process along.

Best regards,

Nat

On Fri, 9 Dec 2016 10:43:28 Paul Goyette wrote:
> On Fri, 9 Dec 2016, I wrote (but not cc'd to source-changes-d):
> > I noticed that you updated spkr.c to retain the existing default behavior
> > of "spkr* at pcppi?"
> > 
> > Do you have any intention to provide a synth_spkr module which would use
> > your new capabilities?  It looks like it would be fairly trivial.
> 
> Also, rather than using #ifdef PCPPISPEAKER to conditionalize large
> chunks of dev/isa/spkr.c it seems to me that a better approach would
> have been to split the existing file into common code, and adding a new
> file for the pcppi attachment stuff.
> 
> 
> 
> +------------------+--------------------------+------------------------+
> 
> | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
> | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
> | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
> 
> +------------------+--------------------------+------------------------+