Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/i386/i386 remove some unsafe sti insns before INTRF...



details:   https://anonhg.NetBSD.org/src/rev/032ef12428b3
branches:  trunk
changeset: 581963:032ef12428b3
user:      yamt <yamt%NetBSD.org@localhost>
date:      Sun Jun 12 05:32:45 2005 +0000

description:
remove some unsafe sti insns before INTRFASTEXIT, which
can allow infinite recursion of the handler.

diffstat:

 sys/arch/i386/i386/vector.S |  5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diffs (33 lines):

diff -r b7f6181753e0 -r 032ef12428b3 sys/arch/i386/i386/vector.S
--- a/sys/arch/i386/i386/vector.S       Sun Jun 12 05:21:25 2005 +0000
+++ b/sys/arch/i386/i386/vector.S       Sun Jun 12 05:32:45 2005 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: vector.S,v 1.18 2005/05/31 00:45:03 chs Exp $  */
+/*     $NetBSD: vector.S,v 1.19 2005/06/12 05:32:45 yamt Exp $ */
 
 /*
  * Copyright 2002 (c) Wasabi Systems, Inc.
@@ -175,7 +175,6 @@
        jmp     _C_LABEL(Xdoreti)
 2:
        orl     $(1 << LIR_IPI),CPUVAR(IPENDING)
-       sti
        INTRFASTEXIT
 
 #if defined(DDB)
@@ -228,7 +227,6 @@
        jmp     _C_LABEL(Xdoreti)
 2:
        orl     $(1 << LIR_TIMER),CPUVAR(IPENDING)
-       sti
        INTRFASTEXIT
 #endif /* NLAPIC > 0 */
 
@@ -312,7 +310,6 @@
 9:                                                                     \
        unmask(num)                                                     ;\
        late_ack(num)                                                   ;\
-       sti                                                             ;\
        INTRFASTEXIT
 
 #define ICUADDR IO_ICU1



Home | Main Index | Thread Index | Old Index