Re: broken src/sys/arch/x86/isa/clock.c (i8254_get_timecount)

[Andrew Doran <ad%netbsd.org@localhost>]

On Thu, Jan 17, 2008 at 10:39:08AM -0500, Thor Lancelot Simon wrote:
> On Thu, Jan 17, 2008 at 10:18:19AM -0500, Chuck Cranor wrote:
> > hi-
> > 
> > On Thu, Jan 17, 2008 at 08:59:48AM +0100, Frank Kardel wrote:
> > > > OK, makes sense.   I did that simple one in HEAD and I'll put in for 
> > > > some
> > > > sort of pullup to netbsd-4.
> > > I interpret that as that you will upgrade to the second solution or Joerg
> > > path then (esp. for the netbsd-4 pullup), right ?
> > 
> > I did the second solution (|| to &&) in HEAD and sent in a pullup for 
> > netbsd-4 for that.
> > 
> > Joerg's patch uses the atomic.h api (atomic_add_32) that isn't present 
> > in netbsd-4, so it cannot be directly applied to that branch.
> 
> Maybe the atomic API should be pulled up?  Even FreeBSD 4 has it.

That wouldn't be a trivial pull-up since it would mean porting in the kernel
restartable sequences that were added.. For x86 an __asm statement could be
used if needs be.

Andrew