Re: WD_QUIRK_FORCE_LBA48

[David Laight <david%l8s.co.uk@localhost>]

On Sat, Dec 05, 2009 at 05:30:39PM +0100, Manuel Bouyer wrote:
> On Sat, Dec 05, 2009 at 03:06:50PM +0000, David Laight wrote:
> > The 'wd' (aka ATA disk) driver has a load of code for the
> > WD_QUIRK_FORCE_LBA48 quirk.
> > 
> > This forces LBA48 transfers for an ever increasing number of disks.
> > 
> > My suspicion is that the problems only relate to transfers that
> > actually cross the LBA48 boundary.
> > 
> > So quite possibly checking:
> >     wd->sc_wdc_bio.blkno + nblks > LBA48_THRESHOLD
> > would remove the need for the quirk.
> 
> This would need to be tested more carefully, but actually this problem is
> detected automatically and the quirk table for these drives should not be
> needed any more (I didn't remove this table just to be conservative).

What about PR/36896 where sector 0 got overwritten.

        David

-- 
David Laight: david%l8s.co.uk@localhost