Re: WD_QUIRK_FORCE_LBA48

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Sat, Dec 05, 2009 at 05:17:29PM +0000, David Laight wrote:
> On Sat, Dec 05, 2009 at 05:30:39PM +0100, Manuel Bouyer wrote:
> > On Sat, Dec 05, 2009 at 03:06:50PM +0000, David Laight wrote:
> > > The 'wd' (aka ATA disk) driver has a load of code for the
> > > WD_QUIRK_FORCE_LBA48 quirk.
> > > 
> > > This forces LBA48 transfers for an ever increasing number of disks.
> > > 
> > > My suspicion is that the problems only relate to transfers that
> > > actually cross the LBA48 boundary.
> > > 
> > > So quite possibly checking:
> > >   wd->sc_wdc_bio.blkno + nblks > LBA48_THRESHOLD
> > > would remove the need for the quirk.
> > 
> > This would need to be tested more carefully, but actually this problem is
> > detected automatically and the quirk table for these drives should not be
> > needed any more (I didn't remove this table just to be conservative).
> 
> What about PR/36896 where sector 0 got overwritten.

This kernel doesn't have the autodetect code, obviously.
With the autodetect code the error message would have something like
Aug 31 11:59:50 30_DEMO_697 /netbsd: wd1g: LBA48 bug writing fsbn 216369024 of 
216369024-216369151 (wd1 bn 268435391; cn 266304 tn 15 sn 14), retrying

Aug 31 11:59:51 30_DEMO_697 /netbsd: wd1: soft error (corrected) 

The autodetect code has been commited to HEAD on 2007/09/16,
and pulled up to various branches one month later.


-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--