Re: RFC: gif(4) MP-ify

[christos%astron.com@localhost (Christos Zoulas)]

In article <567D031F.90604%iij.ad.jp@localhost>,
Kengo NAKAHARA  <k-nakahara%iij.ad.jp@localhost> wrote:
>Hi,
>
>I MP-ify gif(4) interface and ip_encap which is required by gif(4).
>
>Here is the patch
>    http://www.netbsd.org/~knakahara/gif-mp-ify/gif-mp-ify.patch
>
>Could you comment this patch?
>

Looks fine; nits:
- there are spaces missing after commans in macros
- why are you using rw_obj_alloc() since you always need it, and
  you could just define the locks as structs not pointers and call
  rw_init() on them?

christos