Re: RFC: gif(4) MP-ify

[Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>]

Hi christos@n.o,

Thank you for review and comments.

On 2015/12/26 1:11, Christos Zoulas wrote:
> In article <567D031F.90604%iij.ad.jp@localhost>,
> Kengo NAKAHARA  <k-nakahara%iij.ad.jp@localhost> wrote:
>> I MP-ify gif(4) interface and ip_encap which is required by gif(4).
>>
>> Here is the patch
>>    http://www.netbsd.org/~knakahara/gif-mp-ify/gif-mp-ify.patch
>>
>> Could you comment this patch?
>>
> 
> Looks fine; nits:
> - there are spaces missing after commans in macros

I missed it. I will fix it.


> - why are you using rw_obj_alloc() since you always need it, and
>   you could just define the locks as structs not pointers and call
>   rw_init() on them?

I thought leaving a cache alignment to the API might be better than
modifying the variable with __cacheline_aligned manually.

I reconsider, I will use rw_init() and __cacheline_aligned as
riastradh@n.o pointed out.
    http://mail-index.netbsd.org/tech-kern/2015/12/26/msg019838.html


Thanks,

-- 
//////////////////////////////////////////////////////////////////////
Internet Initiative Japan Inc.

Device Engineering Section,
Core Product Development Department,
Product Division,
Technology Unit

Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>