Re: Fix for bootstrapping on macOS

[Pierre Pronchery <khorben%defora.org@localhost>]

On 24/09/2020 20:09, Joerg Sonnenberger wrote:
> On Thu, Sep 24, 2020 at 07:19:18PM +0200, Pierre Pronchery wrote:
> > [sending again with a smaller version of the log]
> >
> > On 23/09/2020 22:28, Joerg Sonnenberger wrote:
> > > On Wed, Sep 23, 2020 at 08:15:43PM +0200, Pierre Pronchery wrote:
> > > > I just tested bootstrapping pkgsrc on macOS with the pkgsrc-2020Q2 branch,
> > > > plus the fix from schmonz@ for the latest version of Xcode. It failed with
> > > > missing function declarations in libarchive.
> > >
> > > What's the actual problem? The patch is certainly not correct.
> >
> > The build log without my patch is attached here.
>
> What Sijmen said, this should have been fixed a while ago.

The fix from schmonz was added in -current.

I am working on and applied it to the 2020Q2 branch, and it made no 
difference, at least when bootstrapping.

Bootstrapping on -current worked without my changes, possibly thanks to 
the fix from schmonz (which turns the error back into a warning instead 
of fixing the underlying issues).

Here are some elements from my system:

> System Version: macOS 10.15.6 (19G2021)                                        
> Kernel Version: Darwin 19.6.0

> $ clang --version
> Apple clang version 12.0.0 (clang-1200.0.32.2)                                 
> Target: x86_64-apple-darwin19.6.0                                              
> Thread model: posix                                                            
> InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

As can be seen in the build log I have provided, it is obvious that 
while bootstrapping, vulnerabilities-file.c from pkg_install makes use 
of <archive.h>, even while bootstrapping (-DBOOTSTRAP). So my fix makes 
sure this header is included unconditionally. It looks good to me, and 
fixes bootstrapping for pkgsrc-2020Q2.

Cheers,
--
khorben