Re: Firefox52 build broken on NetBSD-current (Was: what happened to icui18n ?)

[Martin Husemann <martin%duskware.de@localhost>]

On Wed, Mar 31, 2021 at 08:58:51AM +0200, Martin Husemann wrote:
> Argh - it is caused by something that changed in NetBSD -current.
> 
> I set userland in that chroot back to one compiled from feb 14 sources
> and ff52 is now building.

There is fallout from the RE libary update:

checking for posix_fadvise... yes
checking for posix_fallocate... yes
updating cache ./config.cache
creating ./config.data
sed: 1: "s/--with-system-nspr\S* ...": RE error: trailing backslash (\)
js/src> configuring

... and \S of course is invalid. Should we replace it with [^[:space:]] ?
This is portable everywhere, isn't it?

Martin

Index: patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/www/firefox52/patches/patch-aa,v
retrieving revision 1.3
diff -u -r1.3 patch-aa
--- patch-aa	14 Jun 2019 08:11:35 -0000	1.3
+++ patch-aa	31 Mar 2021 18:49:22 -0000
@@ -5,9 +5,10 @@
 * Add system libraries option
 * Add OSS audio support
 * Add Sun audio support
+* Replace gnu extension in sed pattern with portable version
 
---- old-configure.in.orig	2017-09-11 20:13:47.000000000 +0000
-+++ old-configure.in
+--- old-configure.in.orig	2017-09-11 22:13:47.000000000 +0200
++++ old-configure.in	2021-03-31 20:45:25.040426765 +0200
 @@ -2159,11 +2159,7 @@ if test "$MOZ_SYSTEM_JPEG" = 1; then
                       #include <jpeglib.h> ],
                     [ #if JPEG_LIB_VERSION < $MOZJPEG
@@ -252,3 +253,12 @@
  dnl Check for pixman and cairo
  dnl ========================================================
  
+@@ -5916,7 +6106,7 @@ ac_configure_args="$_SUBDIR_CONFIG_ARGS"
+ 
+ # --with-system-nspr will have been converted into the relevant $NSPR_CFLAGS
+ # and $NSPR_LIBS.
+-ac_configure_args="`echo $ac_configure_args | sed -e 's/--with-system-nspr\S* *//'`"
++ac_configure_args="`echo $ac_configure_args | sed -e 's/--with-system-nspr[^[:space:]]* *//'`"
+ 
+ if test "$_INTL_API" = no; then
+     ac_configure_args="$ac_configure_args --without-intl-api"