Re: Adding threading support to lang/sbcl

[Kevin Bloom <ktnb%netbsd.org@localhost>]

> Kevin Bloom <ktnb%netbsd.org@localhost> writes:
>
> > Okay, so I completely lied. Just re-ran the tests and they do fail
> > when they get to the threads bit.
>
> I think the big question is if any tests that do *not* use threads fail.
>
> Thread support that mostly works is better than no thread support.
>
> Do we think that anything non-threaded is broken by threads being
> enabled?

Here are the two tests results:

=== without threads ===
Finished running tests.
Status:
 Expected failure:   compiler-2.pure.lisp / (MAP-ALLOCATED-OBJECTS NO-CONSING)
 Skipped (broken):   compiler.pure.lisp / FULL-WARNING-FOR-UNDEFINED-TYPE-IN-CL
 Skipped (broken):   compiler.pure.lisp / SINGLE-WARNING-FOR-SINGLE-UNDEFINED-TYPE
 Failure:            compiler.pure.lisp / REDUCING-CONSTANTS
 Skipped (broken):   dynamic-extent.pure.lisp / STACK-ALLOCATED-VECTOR-CHECKS-OVERFLOW
 Failure:            float.pure.lisp / (SCALE-FLOAT-OVERFLOW BUG-372)
 Failure:            float.pure.lisp / (ADDITION-OVERFLOW BUG-372)
 Failure:            float.pure.lisp / (ADDITION-OVERFLOW BUG-372 TAKE-2)
 Expected failure:   hash.pure.lisp / SXHASH-ON-DISPLACED-STRING
 Expected failure:   block-compile.impure.lisp / BLOCK-COMPILE-TOP-LEVEL-CLOSURES.SAME-ENVIRONMENT.LOCAL-CALLS
 Expected failure:   compiler-2.impure.lisp / TOP-LEVEL-CLOSURE-SEPARATE-COMPONENT
 Expected failure:   compiler-2.impure.lisp / TOP-LEVEL-CLOSURE-SEPARATE-COMPONENT.2
 Expected failure:   full-eval.impure.lisp / INLINE-FUN-CAPTURES-DECL
 Skipped (broken):   run-program.impure.lisp / (RUN-PROGRAM AUTOCLOSE-STREAMS)
 Failure:            run-program.impure.lisp / (RUN-PROGRAM CLEAN-EXIT-AFTER-ENCODING-ERROR)
 Failure:            run-program.impure.lisp / (RUN-PROGRAM STOP+CONTINUE)
 Failure:            run-program.impure.lisp / (RUN-PROGRAM STOP+CONTINUE POSIX-KILL)
 Failure:            run-program.impure.lisp / (RUN-PROGRAM CHILD-FD-LEAK)
 Unexpected success: x86-64-codegen.impure.lisp / DISASSEMBLE-ALIEN-LINKAGE-TABLE-REF
 (103 tests skipped for this combination of platform and features)
test failed, expected 104 return code, got 1
=== end without threads ===

=== with threads ===
Finished running tests.
Status:
 Skipped (broken):   compiler.pure.lisp / FULL-WARNING-FOR-UNDEFINED-TYPE-IN-CL
 Skipped (broken):   compiler.pure.lisp / SINGLE-WARNING-FOR-SINGLE-UNDEFINED-TYPE
 Failure:            compiler.pure.lisp / REDUCING-CONSTANTS
 Skipped (broken):   dynamic-extent.pure.lisp / STACK-ALLOCATED-VECTOR-CHECKS-OVERFLOW
 Failure:            float.pure.lisp / (SCALE-FLOAT-OVERFLOW BUG-372)
 Failure:            float.pure.lisp / (ADDITION-OVERFLOW BUG-372)
 Failure:            float.pure.lisp / (ADDITION-OVERFLOW BUG-372 TAKE-2)
 Expected failure:   hash.pure.lisp / SXHASH-ON-DISPLACED-STRING
 Expected failure:   block-compile.impure.lisp / BLOCK-COMPILE-TOP-LEVEL-CLOSURES.SAME-ENVIRONMENT.LOCAL-CALLS
 Invalid exit status: compare-and-swap.impure.lisp
 Expected failure:   compiler-2.impure.lisp / TOP-LEVEL-CLOSURE-SEPARATE-COMPONENT
 Expected failure:   compiler-2.impure.lisp / TOP-LEVEL-CLOSURE-SEPARATE-COMPONENT.2
 Failure:            concurrent-syscalls.impure.lisp / (EXERCISING-CONCURRENT-SYSCALLS)
 Expected failure:   full-eval.impure.lisp / INLINE-FUN-CAPTURES-DECL
 Invalid exit status: gc-threads.impure.lisp
 Skipped (broken):   run-program.impure.lisp / (RUN-PROGRAM AUTOCLOSE-STREAMS)
 Failure:            run-program.impure.lisp / (RUN-PROGRAM CLEAN-EXIT-AFTER-ENCODING-ERROR)
 Failure:            run-program.impure.lisp / (RUN-PROGRAM STOP+CONTINUE)
 Failure:            run-program.impure.lisp / (RUN-PROGRAM CHILD-FD-LEAK)
 (31 tests skipped for this combination of platform and features)
test failed, expected 104 return code, got 1
=== end with threads ===

One note abot the with threads is that I had to disable the threading
tests, profile, and gethash-concurrent tests.