Re: make php to multi packages

[David Brownlee <abs%absd.org@localhost>]

On Tue, 11 Feb 2025 at 05:15, Takahiro Kambe <taca%netbsd.org@localhost> wrote:
>
> Hi,
>
> In message <C776B2A0-0C88-4F38-9FAF-C0A4D09ACB4C%fessel.org@localhost>
>         on Mon, 10 Feb 2025 13:38:55 +0100,
>         oskar%fessel.org@localhost wrote:
> >>> PHP_VERSION_DEFAULT now takes precedence over the installed PHP, breaking nearly all of my builds.
> >>> While this is possibly self-inflicted by building and installing php83 from lang/php83, it is somewhat unexpected.
> >>> Previously phpversion.mk checked what version was installed and selected the appropriate DEFAULT, it is now set to 82.
> >>> From the cvs log it is clear, that the version check is not happening anymore.
>
> I'm sorry for your inconvenience.
>
> Locally, I revivied PHP_CHECK_INSTALLED support diffrenet way.
>
> (1) Only one lang/php?? package is installed,
> (2) PHP_VERSION_DEFAULT is not defined in mk.conf exlicitly,
> (3) Use installed lang/php?? ad PHP_VERSION.
>
> Do you think that (2) is required or not?

I would probably not choose to keep PHP_CHECK_INSTALLED, but if it is present:
- I definitely think (2) would be required.If PHP_VERSION_DEFAULT is
set in mk.conf, then I would expect any newly built package to use it
(providing it is supported by that package), regardless of what is
installed
- I would be happy with a loud warning and short sleep if the logic
was triggered - to let users know that special handling is afoot, and
how to avoid it

Thanks

David