Re: Cross Compile NetBSD on OpenBSD

["Valeriy E. Ushakov" <uwe%stderr.spb.ru@localhost>]

On Sun, Feb 01, 2009 at 17:44:22 +0200, Alan Barrett wrote:

> > The WA() defines seem to be a little different.  The additional ;
> > should not hurt anybody.
> > 
> > Index: lib/libc/hash/hashhl.c
> > ===================================================================
> > RCS file: /data/mirror/netbsd/cvs/src/lib/libc/hash/hashhl.c,v
> > retrieving revision 1.1
> > diff -u -p -r1.1 hashhl.c
> > --- lib/libc/hash/hashhl.c  28 Sep 2005 16:31:45 -0000      1.1
> > +++ lib/libc/hash/hashhl.c  30 Jan 2009 20:58:39 -0000
> > @@ -32,10 +32,10 @@
> >  
> >  #if !defined(_KERNEL) && defined(__weak_alias)
> >  #define    WA(a,b) __weak_alias(a,b)
> > -WA(FNPREFIX(End),CONCAT(_,FNPREFIX(End)))
> > -WA(FNPREFIX(FileChunk),CONCAT(_,FNPREFIX(FileChunk)))
> > -WA(FNPREFIX(File),CONCAT(_,FNPREFIX(File)))
> > -WA(FNPREFIX(Data),CONCAT(_,FNPREFIX(Data)))
> > +WA(FNPREFIX(End),CONCAT(_,FNPREFIX(End)));
> > +WA(FNPREFIX(FileChunk),CONCAT(_,FNPREFIX(FileChunk)));
> > +WA(FNPREFIX(File),CONCAT(_,FNPREFIX(File)));
> > +WA(FNPREFIX(Data),CONCAT(_,FNPREFIX(Data)));
> >  #undef WA
> >  #endif
> 
> It does look harmless to add semicolons here, but I'd like a second
> opinion before I apply this part of your patch.

I think we should drop the final semicolon from __weak_alias
definition &co.  If something is intended to be a self-contained
statement (which __weak_alias clearly is), the semicolon should be
supplied by the caller.

BTW, we should probably use .equiv instead of assignment in those asm
statement, to prohibit redefinition.

SY, Uwe
-- 
uwe%stderr.spb.ru@localhost                       |       Zu Grunde kommen
http://snark.ptc.spbu.ru/~uwe/          |       Ist zu Grunde gehen