Re: [PATCH 0/7] LLDB import to src

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Thu, Apr 02, 2020 at 02:21:53AM +0200, Kamil Rytarowski wrote:
> On 02.04.2020 01:47, Joerg Sonnenberger wrote:
> > On Sat, Mar 28, 2020 at 02:52:03PM +0100, Michał Górny wrote:
> >> This patch series imports LLDB as of the commit matching our LLVM
> >> and Clang (as necessary for API compatibility), backports important
> >> patches improving NetBSD support and adds Makefiles to build it.
> > I'm in the process of upgrading LLVM, but there are a couple of
> > regressions that need to get resolved first. I'll take a look soonish to
> > integrate this, but I don't plan to merge it before that.
> 
> As we upgrade LLVM, we need to upgrade LLDB and drop local cherry-picked
> patches.

Sure, the intention of this part was primary "please focus on keeping
the main line code working".

> 
> On 02.04.2020 01:47, Joerg Sonnenberger wrote:
> >> The build is currently purely using static libraries.  However, I think
> >> we should switch to building and using liblldb.so long-term as upstream
> >> expects us to.  This will require building LLVM and Clang with -fPIC,
> >> and it will then probably make sense to build libLLVM.so
> >> and libclang-cpp.so as well.
> > I don't see any reason why building LLDB dynamically would really
> > improve things given that we don't do Python scripting anyway. Building
> > clang with -fPIC is certainly a big no-go.
> 
> LLDB uses liblldb.so path relative logic internally.
> 
> Python scripting is not something that we want, if anything we might
> want to use Lua scripting but it is not a priority in base.
> 
> But as there is planned an LLVM upgrade, we shall upstream something
> alternative to the liblldb.so path relative logic and avoid local
> patches. Michal, could you have a look into this?

Yes, a compile time option for just hard-coding that path would be much
preferable. Alternatively falling back to the main binary if the shared
library can not be found. But that still feels quite fragile to me.

Joerg