Re: xorg pci probing

[Michael <macallan%NetBSD.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Jan 18, 2011, at 3:31 AM, Christoph Egger wrote:

> On 15.01.11 22:26, Christoph Egger wrote:
> > Hi!
> >
> > I have a machine with two PCI graphic cards:
> > 1x Radeon HD 4200
> > 1x Radeon HD 5600
> >
> > Starting X fails with the error message
> > "Primary device is not PCI"
> >
> > Per discussion with macallen@ I implemented
> > pci_device_is_boot_vga() in libpciaccess
> > which uses a new ioctl().
> >
> > Attached are three patches:
> >
> > xorg_ioctl.diff  which implements the new ioctl
> > xorg.diff        which enable the use of pci_device_is_boot_vga()
> > xsrc.diff        which implements pci_device_is_boot_vga()
> >
> >
> > The three patches let me start X on said machine
> > and I also successfully tested them where X also
> > starts w/o these patches.
>
> I updated my patches based on comments I got from different people.
> I'm resending them for review again.

Jared suggested a KASSERT to make sure the device_t passed to  
wsdisplayio_busid_pci() is actually a PCI bus child. Otherwise it  
looks good to me.

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBTTZGKcpnzkX8Yg2nAQLVxQf9HQs0KsJFoFTQjiIT/A48hsrde0JzEpdZ
nPfedA44G7QPRyLESRYUX7UP3O6RaPi7f82S03SUaQgbo8sKFeFtrXBopzPJsTQo
FM2FgX78MWxnI0MjrAUYKe4+4KZIXXvMrapAC2hU314YZnD5TKkKc/u5/mex68ew
gUxnE1EEh4D35+UffzyR046dqRFTveNzJFCY/xOwkMe8BRSSDVK/cS01N0RB764q
IMAIlfOO2WGcAKoE0bol1vc0TnY8KpCh929OJf5rD+w6ohcGVVMKCz6oXJMWRoLn
YKni0PiDj8tmaGk28mgGH2TOSwqYa99bkyaGZRutL0G2li2Bo0vrMg==
=SZ+d
-----END PGP SIGNATURE-----