Re: xorg pci probing

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

On 19.01.11 03:02, Michael wrote:
> Hello,
> 
> On Jan 18, 2011, at 3:31 AM, Christoph Egger wrote:
> 
>> On 15.01.11 22:26, Christoph Egger wrote:
>>>
>>> Hi!
>>>
>>> I have a machine with two PCI graphic cards:
>>> 1x Radeon HD 4200
>>> 1x Radeon HD 5600
>>>
>>> Starting X fails with the error message
>>> "Primary device is not PCI"
>>>
>>> Per discussion with macallen@ I implemented
>>> pci_device_is_boot_vga() in libpciaccess
>>> which uses a new ioctl().
>>>
>>> Attached are three patches:
>>>
>>> xorg_ioctl.diff  which implements the new ioctl
>>> xorg.diff        which enable the use of pci_device_is_boot_vga()
>>> xsrc.diff        which implements pci_device_is_boot_vga()
>>>
>>>
>>> The three patches let me start X on said machine
>>> and I also successfully tested them where X also
>>> starts w/o these patches.
> 
>> I updated my patches based on comments I got from different people.
>> I'm resending them for review again.
> 
> Jared suggested a KASSERT to make sure the device_t passed to
> wsdisplayio_busid_pci() is actually a PCI bus child.

Yes, I did that in my local tree as I mentioned in an earlier mail.
I just didn't resend the patch for a tiny change.

> Otherwise it looks good to me.

Thanks. I will commit it then.

Christoph