Re: CVS commit: pkgsrc/devel/gettext-lib

["OBATA Akio" <obache%netbsd.org@localhost>]

On Sun, 02 Sep 2012 16:01:49 +0900, John Marino <netbsd%marino.st@localhost> 
wrote:

> On 9/2/2012 04:59, OBATA Akio wrote:
> > As I already said:
> >
> > > > > > For such cases, need to pass BUILDLINK_DIR instead of
> > > > > > BUILDLINK_PREFIX.gettext
> > > > > > to configure script.
> >
> > You should use ${BUILDLINK_DIR} instead of ${WRKDIR}/.buildlink.
> >
> > But this kind of trick may introduce potentially $WRKDIR reference
> > injection
> > into the result of built, so it should be taken carefully.
>
> I understand.
> In this particularly case, I think using BUILDLINK_DIR fixes the build
> correctly.  The whole gettext-lib modification is essentially "a trick"
> so php-gettext needs another trick to restore it on platforms like
> DragonFly.
>
> My bulk build finished last night, the one where I applied the
> gettext-lib/buildlink3.mk patch.  I did not see any more gettext-lib
> related package failures.
>
> So:
> 1) I think the gettext-lib modification made by SD can stay in place
> 2) You should commit the gettext-lib/buildlink3.mk patch
> 3) I will commit the update to php-gettext
>
> What do you think?

For builtin gettext, its libintl.h should be linked into 
${BUILDLINK_DIR}/include,
or builtin libintl.h may not be found by configure script.

--
OBATA Akio / obache%NetBSD.org@localhost