Re: wip patch for using external git command

[Greg Troxel <gdt%lexort.com@localhost>]

Aleksey Cheusov <vle%gmx.net@localhost> writes:

>> Aleksey Cheusov <vle%gmx.net@localhost> writes:
>
>  >> On non-NetBSD systems I'd like to use external git command in WIP.
>  >> Is there objections against the following patch?
>
>> Why is this not just an instance of the tools platform finding and
>> accepting a native tool, rather than patching something not to use the
>> tools framework?   It seems like the change is in the wrong place.
>
> As far as I can see wip/mk/git-package.mk itself does not
> use tools framework.

That seems like backwards logic.

You are basically saying

  makefiles just call git

  I want a different git to be used

and this is essentially what the tools framework does:

  allow to declare that something is needed

  find it and set a path on various systems (e.g. in platform/foo.mk)

  depend on and build a version from pkgsrc if there is no builtin or
  it's not good enough

  allow the user to override path/choice

and you are basically proproposing to reimplement part of this ad-hoc
with custom variables.  I see this as a regression in regularizing and
simplifying what is in pkgsrc, and therefore I object to it.

So if you want to add support for custom git, I think we first need git
as a tool.

Right now, what happens if you try to build a git-package.mk-using
package on a system without git?