I propose to pick sysctl, as it is already an existing interface to do this work and it does not need to version syscalls. Versioning syscalls costs, especially in testing older code-paths. On 22.09.2019 17:15, Christos Zoulas wrote: > Well, it is less natural and the programs need to so something special to get the information. > Anyway if people prefer the sysctl patch we can do that instead. OTOH it is very instructive > to see how much work is needed to version a syscall in a single commit :-) > > christos > >> On Sep 22, 2019, at 10:55 AM, Kamil Rytarowski <n54%gmx.com@localhost> wrote: >> >> Signed PGP part >> On 22.09.2019 15:39, Christos Zoulas wrote: >>> In article <qlvug6$6lbg$1%blaine.gmane.org@localhost>, >>> Christos Zoulas <christos%astron.com@localhost> wrote: >>>> In article <qlvhpb$eq5$1%serpens.de@localhost>, >>>> Michael van Elst <mlelstv%serpens.de@localhost> wrote: >>>>> christos%astron.com@localhost (Christos Zoulas) writes: >>>>> >>>>>> I added that to df, but it needs root/operator in order to access the >>>>>> device node to get wedge info. I also wrote a patch to expose the >>>>>> wedge info via sysctl: >>>>> >>>>> Alternatives ? >>>>> >>>>> Expose via an enhanced statvfs() syscall. After all df is a user interface >>>>> for that syscall. It would at least allow in theory to return a copy >>>>> of the exact mount path. >>>> >>>> Yes, this is the first thing I thought. I will see how feasible it it. >>> >>> I've implemented this but the patch is fairly long (due to the 4 syscalls >>> that need to be versioned). Anyway it works, and once I get a successful >>> build I will post the pstch here. >>> >>> christos >>> >> >> What's wrong with sysctl? >> >> It works nicely and this use-case is not performance sensitive. >> >> >> <sanitizer.log> >
Attachment:
signature.asc
Description: OpenPGP digital signature