Re: [patch] PCI memory & i/o enables

[Matthias Drochner <M.Drochner%fz-juelich.de@localhost>]

dyoung%pobox.com@localhost said:
> If the flag isn't set, the driver has no business setting it.  Also,
> if the flag isn't set, there's not much use in the driver setting the
> corresponding bit in the PCI CSR.

I don't think this goes into the right direction. The driver shouldn't
have a business setting flags in the attach args, except in rare,
mostly historical cases like indirect configuration. And the driver
shouldn't enable address decoding in the PCI CSR because it has
no way to check whether the BARs are set to reasonable values.
Such things belong into the framework, the mapreg_map() or so functions.

best regards
Matthias



------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzender des Aufsichtsrats: MinDirig Dr. Karl Eugen Huthmacher
Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt
------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------

Besuchen Sie uns auf unserem neuen Webauftritt unter www.fz-juelich.de