Re: net/megacmd update to 1.7.0

[Greg Troxel <gdt%lexort.com@localhost>]

Robert Bagdan <kikadf.01%gmail.com@localhost> writes:

> Thanks for your comments, let me answer on these points.
>
> 1) DESCR:
> MEGA is similar to Dropbox, it is a cloud provider. Megacmd is one of
> their official tools to use their services. It is free, and open
> source. Is it a more understandable description?
>
> “MEGA brings cloud storage, file and folder sharing, chat, meetings,
> and more - together into one place. MEGAcmd is a free, open source
> tool that provides non UI access to MEGA services. It intends to offer
> all the functionality with your MEGA account via commands. It features
> synchronization, backup of local folders into your MEGA account and a
> webdav/streaming server. ”

Generally, it's best if DESCR is descriptive without sounding like it
was written by a marketing person.   

> 2) MESSAGE:
> That is already in pkgsrc, and I added the MESSAGE file, because I
> can’t find a  better way to show this information. But I read the
> guide, yes, it isn’t a lucky way to make a notice to the user. However
> it is not an upstream bug (manually step to generate machine-id),
> because NetBSD (or any BSD) isn't a supported platform, on the
> supported platforms (eg.: linux) /etc/machine-id exist. I can
> transform the MESSAGE file to share/doc/megacmd/README, if this is a
> better way to give this information to the users.

People are expected to read the documentation, basically.  Trying to use
MESSAGE to push it at them isn't ok.   

Not supporting NetBSD is a bug :-) I am unclear on whether this is a
dbus problem (dbus interface says there is an id and on NetBSD it
doesn't get created), or a megacmd problem (it asks for something that
isn't part of the dbus spec.

> 3) PATCHES:
> Officially megacmd supports Windows/Mac/Linux, but works on all BSDs
> as well. I sent pull requests to adopt patches, but they didn’t accept
> them, and I think BSDs aren’t their target.
>
> Pull requests:
> https://github.com/meganz/sdk/pull/2662
> https://github.com/meganz/sdk/pull/2663
> https://github.com/meganz/sdk/pull/2664
> https://github.com/meganz/sdk/pull/2665
> https://github.com/meganz/MEGAcmd/pull/949
>
> I document the patch files, add the relevant upstream pull request links.

That's unfortunate, but yes, closed pull requests are a fair URL for patches.

> 4) CXXFLAGS:
> I cleaned the CXXFLAGS from –std, and used the FORCE_CXX_STD (the
> build failed without FORCE_CXX_STD). Built fine, and the package works
> for me on amd64, NetBSD-10.

Sounds like progress.  Also an upstream bug; if it needs a --std it
should set it.

> I pushed the changes to pkgsrc-wip, I hope this looks better. If in 2)
> the README file is the best way, I transform the MESSAGE file as well.

README is best if upstream won't document it.  It doesn't meet the rules
for MESSAGE, so that isn't an option.


Also, is the upstream for megacmd the MEGA company?   They seem to be
somewhat problematic in rejecting reasonable PRS.